Restore old cluster file format for compatibility with python code #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we change the python code? I'd strongly prefer having the new lines, having had to look through cluster assignments / debugging. |
|
Can you give me an example of where the new lines help? Because I've looked at a few of the cluster output files, and I'm really having a hard time seeing how the new format is an improvement over the old one. |
|
I'll approve, but will just say I've been frustrated debugging without the new lines. I don't have a file handy on me, but basically large clusters or the many cluster case have been very annoying to read IMO, and I've wasted time on parsing them. |
srvasude
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #176