Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend make_plots.py to handle schemas with more than one domain #208

Merged
merged 4 commits into from
Sep 24, 2024

Conversation

ThomasColthurst
Copy link
Collaborator

As part of that, it now takes an optional --schema parameter, and there is schema reading code in hirm_io.py.

Sample output (from running on the output of hirm over the two_relations dataset):
download

py/hirm_io.py Outdated
with open(path, 'r') as f:
for line in f:
if comment_line_re.match(line):
next
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be continue. Maybe add a test with a comment line?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done and done. The test revealed another bug (in the regex) which I've also fixed.

@ThomasColthurst ThomasColthurst merged commit 50c346b into master Sep 24, 2024
2 checks passed
@ThomasColthurst ThomasColthurst deleted the 092024-thomaswc-pyschema branch September 24, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants