Extend make_plots.py to handle schemas with more than one domain #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srvasude
approved these changes
Sep 24, 2024
py/hirm_io.py
Outdated
| with open(path, 'r') as f: | ||
| for line in f: | ||
| if comment_line_re.match(line): | ||
| next |
There was a problem hiding this comment.
This should be continue. Maybe add a test with a comment line?
There was a problem hiding this comment.
Done and done. The test revealed another bug (in the regex) which I've also fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of that, it now takes an optional --schema parameter, and there is schema reading code in hirm_io.py.
Sample output (from running on the output of hirm over the two_relations dataset):
