Restore pclean's ability to output its clusters #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilyfertig
approved these changes
Oct 3, 2024
cxx/pclean/pclean_lib.cc
Outdated
| T_encoding_r code_to_item; | ||
|
|
||
| for (const auto& [domain, crp] : gendb.domain_crps) { | ||
| for (int i = 0; i < crp.max_table(); ++i) { |
There was a problem hiding this comment.
Should this include max table? (i.e. <= instead of <)
There was a problem hiding this comment.
Yes. Fixed.
cxx/pclean/pclean_lib_test.cc
Outdated
|
|
||
| gendb.incorporate(prng, {0, obs}, true); | ||
|
|
||
| BOOST_TEST(enc.second["School"][0] == "School:0"); |
There was a problem hiding this comment.
Consider looping over domain_crps.at("School").tables to make sure all the values are accounted for.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #222