Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Github Actions for Format + Testing #29

Merged
merged 6 commits into from
Jun 4, 2024

Conversation

srvasude
Copy link
Collaborator

@srvasude srvasude commented May 29, 2024

Github Action for CI.

  • I've removed the formatting action, because there were version diffs on what github was installing and what's at Google and was getting different results when I tried to keep these as close as possible (Google's depends on Clang 19.0 for example which isn't released yet).

  • I've added a .clang-format file to at least make these changes uniform.

  • Fixed tests at HEAD (adapter_test was broken by recent normal changes).

  • Clang-formatted rest of code base.

# This is the 1st commit message:

Add Clang format and Continuous Integration

# This is the commit message #2:

Fix typo for continuous-integration

# This is the commit message #3:

Build and Test w.r.t CXX since there is no BUILD file at the top level

# This is the commit message #4:

Update to only test pushes to main

# This is the commit message #5:

Rename to dash to be consistent

# This is the commit message #6:

Fix clang-format command
Fix typo for continuous-integration

Build and Test w.r.t CXX since there is no BUILD file at the top level

Update to only test pushes to main

Rename to dash to be consistent

Fix clang-format command

Update code to be clang-formatted. This is to be compatible with later presubmits

Ensure clang runs

Fix clang-format command

clang-format Google style

Add config for Google style clang-format, so external users share same formatting

Update clang-format file

Actually add .clang-format file

Update tests for clang-format

Figure out config differences, by adding changed config

Figure out config differences, by adding changed config

Figure out config differences, by adding changed config

Ensure config remains the same across devices

Update clang-format since github version is not the same

Update clang-format since github version is not the same

Use a newer version of clang-format

Use a newer version of clang-format

Use a newer version of clang-format

Use a newer version of clang-format

Use a newer version of clang-format

Use a newer version of clang-format

Use a newer version of clang-format

Use a newer version of clang-format

Use a newer version of clang-format

Fix two big bugs in Normal

update to see test errors

Fix adapter_test

Remove clang-format workflow for now
@srvasude srvasude force-pushed the 052924-srvasude-github-actions branch from c785f69 to f3809d3 Compare May 30, 2024 22:42
@srvasude srvasude requested a review from emilyfertig May 30, 2024 23:03
cxx/distributions/adapter_test.cc Outdated Show resolved Hide resolved
cxx/tests/test_util_math.cc Outdated Show resolved Hide resolved
@srvasude srvasude merged commit b4e3c7b into master Jun 4, 2024
1 of 2 checks passed
@srvasude srvasude deleted the 052924-srvasude-github-actions branch June 4, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants