Add Github Actions for Format + Testing #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# This is the 1st commit message: Add Clang format and Continuous Integration # This is the commit message #2: Fix typo for continuous-integration # This is the commit message #3: Build and Test w.r.t CXX since there is no BUILD file at the top level # This is the commit message #4: Update to only test pushes to main # This is the commit message #5: Rename to dash to be consistent # This is the commit message #6: Fix clang-format command
Fix typo for continuous-integration Build and Test w.r.t CXX since there is no BUILD file at the top level Update to only test pushes to main Rename to dash to be consistent Fix clang-format command Update code to be clang-formatted. This is to be compatible with later presubmits Ensure clang runs Fix clang-format command clang-format Google style Add config for Google style clang-format, so external users share same formatting Update clang-format file Actually add .clang-format file Update tests for clang-format Figure out config differences, by adding changed config Figure out config differences, by adding changed config Figure out config differences, by adding changed config Ensure config remains the same across devices Update clang-format since github version is not the same Update clang-format since github version is not the same Use a newer version of clang-format Use a newer version of clang-format Use a newer version of clang-format Use a newer version of clang-format Use a newer version of clang-format Use a newer version of clang-format Use a newer version of clang-format Use a newer version of clang-format Use a newer version of clang-format Fix two big bugs in Normal update to see test errors Fix adapter_test Remove clang-format workflow for now
srvasude
force-pushed
the
052924-srvasude-github-actions
branch
from
c785f69
to
f3809d3
Compare
…into 052924-srvasude-github-actions
emilyfertig
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github Action for CI.
I've removed the formatting action, because there were version diffs on what github was installing and what's at Google and was getting different results when I tried to keep these as close as possible (Google's depends on Clang 19.0 for example which isn't released yet).
I've added a .clang-format file to at least make these changes uniform.
Fixed tests at HEAD (adapter_test was broken by recent normal changes).
Clang-formatted rest of code base.