Add SimpleStringEmission and re-enable GaussianEmission test #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilyfertig
approved these changes
Jun 13, 2024
| return; | ||
| } | ||
|
|
||
| if (clean[0] == dirty[0]) { |
There was a problem hiding this comment.
This is clever and it took me a little while to understand. Consider adding some explanatory comments to the first couple blocks like "Check equality of string prefixes" before line 50 and "Check equality of string suffixes" before line 66.
cxx/emissions/simple_string.hh
Outdated
| if (mode == '\0') { | ||
| return clean; | ||
| } | ||
| clean = clean + mode; |
There was a problem hiding this comment.
Probably inconsequential but IMO might as well use += since it calls append instead of copying the string (https://stackoverflow.com/questions/611263/efficient-string-concatenation-in-c/30401747#30401747)
| ss.incorporate(std::make_pair<std::string, std::string>("world", "w0rld!")); | ||
| BOOST_TEST(ss.N == 2); | ||
|
|
||
| BOOST_TEST(ss.logp(std::make_pair<std::string, std::string>("test", "tst")) < 0.0); |
There was a problem hiding this comment.
We'd expect logp("test", "te$t") > logp("test", "tst") since one substitution and no deletions are incorporated, right? Could you add a test like that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.