Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add marginal tests for Zero Mean Normal, and fix bugs in logp/logp_score #62

Merged
merged 6 commits into from
Jun 25, 2024

Conversation

srvasude
Copy link
Collaborator

Add tests that numerically integrate to find logp and logp_score.

  • Fix bug in logp and logp_score.
  • Use log1p in Student-T calculation for better numerical stability.

Copy link
Collaborator

@ThomasColthurst ThomasColthurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea why the pre-commit.ci check is failing (for this and other pull requests)?

cxx/distributions/zero_mean_normal.cc Show resolved Hide resolved
cxx/distributions/zero_mean_normal.cc Show resolved Hide resolved
cxx/distributions/zero_mean_normal.cc Show resolved Hide resolved
@srvasude srvasude merged commit a3129fc into master Jun 25, 2024
1 of 2 checks passed
@srvasude srvasude deleted the 061324-srvasude-emission_test branch July 16, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants