Big factors plus irm_test plus integration test of transition_hyperparameters #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ThomasColthurst
commented
Jun 18, 2024
ThomasColthurst
commented
- :hirm is broken up into :irm, :hirm_lib and :hirm.
- :headers is removed
- :relation_variant is split off from :util_distribution_variant in order to avoid cyclic dependencies.
- A pretty small irm_test is added.
- test_irm_two_relations.cc is upgraded to use single_step_irm_inference, and because of that must set the distribution hyperparameters from the IRM that is loaded from disk.
- Fixed an unused variable warning in relation_test.cc
emilyfertig
approved these changes
Jun 18, 2024
| @@ -1,8 +1,9 @@ | |||
| // Copyright 2024 | |||
| // See LICENSE.txt | |||
|
|
|||
| // This file collects classes/functions that depend on the set of distribution | |||
| // subclasses and should be updated when a new subclass is added. | |||
| // Classes and functions for dealing with Distributions and their values in a | |||
There was a problem hiding this comment.
Could you update the comment on lines 7-8 of the Distribution base class too?
| #include <boost/test/included/unit_test.hpp> | ||
| namespace tt = boost::test_tools; | ||
|
|
||
| BOOST_AUTO_TEST_CASE(test_irm) { |
There was a problem hiding this comment.
Could you add a test for logp? Maybe something like this (assuming I understand correctly):
double logp_score0 = irm.logp_score();
double logp1 = irm.logp(x);
irm.incorporate(x);
double logp_score1 = irm.logp_score();
BOOST_TEST(logp_score1 == logp_score0 + logp1);
(Or fine to do in a follow-up, if you or Srinivas are planning on expanding test coverage/adding HIRM tests later.)
There was a problem hiding this comment.
Well, I added that test, which I also expected to pass, but it didn't. Added a TODO for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.