Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Change nonconjugate class to keep a running logp score" #68

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

ThomasColthurst
Copy link
Collaborator

This reverts commit fc91153.

I remembered why it is important to memorize the data and have logp_score compute the log probabilities -- it is because the latent variables can change after the data has been incorporated.

@emilyfertig
Copy link
Collaborator

Aha good point.

@emilyfertig emilyfertig merged commit 31b0b3d into master Jun 21, 2024
1 of 2 checks passed
@emilyfertig emilyfertig deleted the 062124-thomaswc-nonconj3 branch June 21, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants