Add emission class for Categorical distributions #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilyfertig
reviewed
Jul 8, 2024
cxx/emissions/categorical.hh
Outdated
| if (std::cmp_equal(i, x.first)) { | ||
| lp += emission_dists[i].logp(x.second); | ||
| } else { | ||
| lp += emission_dists[i].logp_score(); |
There was a problem hiding this comment.
Could you explain this formula for logp? I thought it should be p(x.second | x.first), where x.first is clean and x.second is noisy, such that the conditional probability in the if branch was all we needed. Also, to the extent that this is like a bigram model, the bigram logp doesn't contain logp_score terms for the rest of the categories.
There was a problem hiding this comment.
You are entirely correct; this should only contain the conditional probability. Fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A later pull request will have the upgrades to the Sometimes emissions adapter that will let it be used in conjunction with this.