Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build by upgrading CategoricalEmission::incorporate to take a weight #78

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

ThomasColthurst
Copy link
Collaborator

No description provided.

emission_dists[x.first].incorporate(x.second);
}

void unincorporate(const std::pair<int, int>& x) {
Copy link
Collaborator

@srvasude srvasude Jul 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should unincorporate be deleted?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. The base.hh Distribution class defines unincorporate(x) to just be incorporate(x, -1.0) and that definition is totally appropriate here.

@ThomasColthurst ThomasColthurst merged commit 1276c8f into master Jul 9, 2024
1 of 2 checks passed
@ThomasColthurst ThomasColthurst deleted the 070924-thomaswc-fixbuild branch July 9, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants