Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Unincorporate to Domain/Clean Relation #83

Merged
merged 3 commits into from
Jul 11, 2024

Conversation

srvasude
Copy link
Collaborator

Adds back methods for unincorporating in a domain or clean relation (which propagates to unincorporating correctly in irm and hirm).

Add some tests to check unincorporating works.

Copy link
Collaborator

@emilyfertig emilyfertig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

cxx/clean_relation.hh Outdated Show resolved Hide resolved
cxx/clean_relation.hh Outdated Show resolved Hide resolved
cxx/clean_relation_test.cc Show resolved Hide resolved
Copy link
Collaborator

@emilyfertig emilyfertig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@srvasude srvasude merged commit 7137939 into master Jul 11, 2024
2 checks passed
@srvasude srvasude deleted the 071124-srvasude-add_unincorporate branch July 16, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants