-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add trace support for IDONTWANT control messages #37
Conversation
I've been testing locally the changes (using the
The only thing that worries me is that there seems to be a specific Control RPC for each of the IDONTWANT messages (I need to check if this is an intended behaviour) |
var _ DataStream = (*TraceLogger)(nil) | ||
|
||
func (t *TraceLogger) Start(ctx context.Context) error { | ||
<-ctx.Done() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
blocking on the context isn't necessary IIUC
<-ctx.Done() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Decription
After the recent addition of
IDONTWANT
messages to thego-libp2p-pubsub
repo (GossipSubv1.2
), this PR aims to extend the libp2p/gossipsub tracer to track these same messages.Some extra features:
go-libp2p
and thego-libp2p-pubsub
dependencies.data-streamer
with a new flag a theapp-root
level.build
,install
, andformat
the code