Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RTT terminal creation #88

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Fix RTT terminal creation #88

merged 1 commit into from
Mar 12, 2024

Conversation

hyx0329
Copy link
Contributor

@hyx0329 hyx0329 commented Mar 12, 2024

Currently RTT terminals won't be created even when RTT is configured correctly. This patch fix the problem.

noppej
noppej approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@noppej noppej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for digging into this and fixing it. I can confirm intermittent cases where the terminal windows would not open, but could never quite pin it down to a specific cause.

@noppej
Copy link
Contributor

noppej commented Mar 12, 2024

@hyx0329 We will release this fix as part of a the next update. In the interim, you can run the package script from inside your dev environment, which will produce a new .vsix of the extension. If you right-click on that, you can install the 'patched' version of the extension.

@noppej noppej linked an issue Mar 12, 2024 that may be closed by this pull request
RTT Terminals won't show up #87
Closed
@noppej noppej merged commit 2d8cf18 into probe-rs:master Mar 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noppej noppej noppej approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RTT Terminals won't show up
2 participants
@hyx0329 @noppej