Skip to content

Commit

Permalink
ci: fix notification workflows used during releases (#3157)
Browse files Browse the repository at this point in the history
The event send by the "npm publish" workflow was incorrect, it didn't
correctly integrate the configuration tested in the playground
repository.
The workflow notifying the R package included 2 issues
  - the internal action wasn't checkout
  - the name of the target repository contained a typo

The problems above have impacted the release of version `0.44.0`.
Running the fixed workflow manually fixed the problems for this
particular release.
  • Loading branch information
tbouffard authored Aug 30, 2024
1 parent 846e593 commit 6dca528
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
4 changes: 3 additions & 1 deletion .github/workflows/notify-new-version-available-on-npm.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,10 @@ jobs:
strategy:
matrix:
repository:
- bpmn-visualization-R'
- bpmn-visualization-R
steps:
# Need to checkout to access to the internal action
- uses: actions/checkout@v4
- name: Notify that a new bpmn-visualization version is available
uses: ./.github/actions/notify-PA-repo-of-new-version
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish-npm.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
with:
# use the default GITHUB_TOKEN, this is possible because we are dispatching the same repository
event-type: new_version_available_on_npm
client-payload: '{ "version": "${{ inputs.version }}" }'
client-payload: "{ version: ${{ inputs.version }} }"
- name: Send message to Slack channel
if: success()
uses: slackapi/[email protected]
Expand Down

0 comments on commit 6dca528

Please sign in to comment.