Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INFRA] Share the eslint configuration #2771

Open
tbouffard opened this issue Jul 19, 2023 · 0 comments
Open

[INFRA] Share the eslint configuration #2771

tbouffard opened this issue Jul 19, 2023 · 0 comments
Labels
chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...)

Comments

@tbouffard
Copy link
Member

tbouffard commented Jul 19, 2023

bpmn-visualization uses it own dedicated eslint configuration but we have the we have the same need in several repositories.
For demos, we recently experiment xo that also allows shared configuration but we didn't setup it.
Some other repositories that need a linter configuration

The website has its own eslint configuration which initially duplicated from the configuration of this repository.

So, it's time to consider to create one or several shared configurations

We could start by extracting the configuration and create a first shared configuration for TypeScript browser project.

Prerequisites

IMPORTANT: requires to implement #2078 and #2742 first

Prettier configuration

Editor configuration

Notice plugin (license header)

  • it is currently stored in a dedicated configuration file. Investigate if it can be integrated in a shared eslint configuration

Editor configuration

  • a .editorconfig file exists in the repo to provide some styling config for JS/TS and documentation (markdown, adoc, ...)
  • See if it can be shared or removed in favor of prettier/eslint or other configuration
    -Find alternatives for (see below)

Review the configuration of the demo repositories (xo) and evaluate adding new rules

Alternatives for .editorconfig

We may need to introduce linter for markdown and AsciiDoc

Share the configuration

Create a dedicated repository to host the shared configuration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...)
Projects
None yet
Development

No branches or pull requests

2 participants