Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(eslint): add some ESlint configuration #1178

Merged
merged 4 commits into from
Oct 9, 2023

Conversation

csouchet
Copy link
Member

@csouchet csouchet commented Oct 9, 2023

ℹ️ Based on our team's decision, we no longer require approval of the refactoring pull request. Instead, we will review and approve the refactoring once all changes related to a specific component have been completed.

Based on bpmn-visualization configuration:

  • Add eslint-plugin-import and eslint-import-resolver-typescript.
  • Update TS configuration
  • Add some @typescript-eslint rules

@csouchet csouchet added the chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) label Oct 9, 2023
@csouchet csouchet force-pushed the add_some_eslint_configuration branch from 09214f1 to 57da40c Compare October 9, 2023 14:05
@github-actions
Copy link

github-actions bot commented Oct 9, 2023

♻️ PR Preview 5a65645 has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

@tbouffard
Copy link
Member

I don't understand why such a PR is created.
We plan to reduce the work effort devoted to this repository, and plan to share the eslint configuration between repositories (process-analytics/bpmn-visualization-js#2771).

@csouchet
Copy link
Member Author

csouchet commented Oct 9, 2023

I don't understand why such a PR is created. We plan to reduce the work effort devoted to this repository, and plan to share the eslint configuration between repositories (process-analytics/bpmn-visualization-js#2771).

I implement it, because there is a lot of warning messages in the terminal console, and make me very painful to find the link of the page and read all the errors.

ℹ️ As I take a part of the configuration of bpmn-visualization, it take me at most 10 minutes to copy, paste, test, fix the pull request. So, it's not a long time for the gain after 🙂

@csouchet csouchet marked this pull request as ready for review October 9, 2023 15:06
@csouchet csouchet merged commit a3145d4 into main Oct 9, 2023
3 checks passed
@csouchet csouchet deleted the add_some_eslint_configuration branch October 9, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants