Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(eslint): use eslint-plugin-jest-extended #2820

Merged
merged 3 commits into from
Aug 25, 2023
Merged

chore(eslint): use eslint-plugin-jest-extended #2820

merged 3 commits into from
Aug 25, 2023

Conversation

csouchet
Copy link
Member

@csouchet csouchet commented Aug 25, 2023 •
edited by tbouffard
Loading

This pull request introduces changes to enhance the code quality and maintainability of the project.

  • Added eslint-plugin-jest-extended as a development dependency.
  • Updated the ESLint configuration for the test files to use the rules of eslint-plugin-jest-extended.
  • Fixed linting issues detected by eslint-plugin-jest-extended.

Covers #2742

@csouchet csouchet added the chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) label Aug 25, 2023
@csouchet csouchet changed the title chore(eslint): add eslint-plugin-jest-extended chore(eslint): add eslint-plugin-jest-extended dependency Aug 25, 2023
@csouchet csouchet added the dependencies Pull requests that update a dependency (dev or runtime) label Aug 25, 2023
@github-actions
Copy link

github-actions bot commented Aug 25, 2023 •
edited
Loading

♻️ PR Preview a4fb8b5 has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

@github-actions
Copy link

github-actions bot commented Aug 25, 2023 •
edited
Loading

♻️ PR Preview a4fb8b5 has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

@csouchet csouchet mentioned this pull request Aug 25, 2023
Open
23 tasks
@sonarcloud
Copy link

sonarcloud bot commented Aug 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@csouchet csouchet marked this pull request as ready for review August 25, 2023 13:02
tbouffard
tbouffard approved these changes Aug 25, 2023
View reviewed changes
Copy link
Member

@tbouffard tbouffard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tbouffard tbouffard changed the title chore(eslint): add eslint-plugin-jest-extended dependency chore(eslint): use eslint-plugin-jest-extended Aug 25, 2023
@csouchet csouchet merged commit 4c2c0f9 into master Aug 25, 2023
30 checks passed
@csouchet csouchet deleted the 2742-add_eslint-plugin-jest-extended_rules branch August 25, 2023 15:40
@tbouffard tbouffard added skip-changelog Do not include in Changelog and Release Notes and removed dependencies Pull requests that update a dependency (dev or runtime) skip-changelog Do not include in Changelog and Release Notes labels Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbouffard tbouffard tbouffard approved these changes

Assignees
No one assigned
Labels
chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@csouchet @tbouffard