Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(eslint): add unicorn/prefer-add-event-listener rule #2867

Merged
merged 2 commits into from
Sep 21, 2023

Conversation

csouchet
Copy link
Member

@csouchet csouchet commented Sep 19, 2023

To avoid to have to many changes by enabling plugin:unicorn/recommended, I choose to enable some rule one-by-one.

https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/prefer-add-event-listener.md

Part of #2824 

⚠️  For the code coverage, it was already the case before this PR.

Covers #2742

@csouchet csouchet added chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) depends on another PR ⚠️ Pull request depending on another one. The depending must be merged first refactoring Code refactoring labels Sep 19, 2023
@github-actions
Copy link

github-actions bot commented Sep 19, 2023

🎊 PR Preview 007e5fc has been successfully built and deployed to https://process-analytics-bpmn-visualization-js-doc_preview-pr-2867.surge.sh

🕐 Build time: 0.014s

🤖 By surge-preview

@github-actions
Copy link

github-actions bot commented Sep 19, 2023

♻️ PR Preview c222992 has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

@sonarcloud
Copy link

sonarcloud bot commented Sep 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

82.3% 82.3% Coverage
0.0% 0.0% Duplication

@csouchet csouchet removed the depends on another PR ⚠️ Pull request depending on another one. The depending must be merged first label Sep 20, 2023
@csouchet csouchet force-pushed the 2742-add_unicorn/prefer-add-event-listener_rule branch from 007e5fc to c222992 Compare September 20, 2023 15:35
@csouchet csouchet marked this pull request as ready for review September 20, 2023 15:36
@csouchet csouchet merged commit 605fd60 into master Sep 21, 2023
5 checks passed
@csouchet csouchet deleted the 2742-add_unicorn/prefer-add-event-listener_rule branch September 21, 2023 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) refactoring Code refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants