chore(eslint): add unicorn/consistent-function-scoping rule
#2873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csouchet
added
chore
|
♻️ PR Preview 1f90bed has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
|
🎊 PR Preview 1f90bed has been successfully built and deployed to https://process-analytics-bpmn-visualization-js-doc_preview-pr-2873.surge.sh 🕐 Build time: 0.017s
🤖 By surge-preview |
…/consistent-function-scoping (cherry picked from commit 356891b4eb9659d019ccfc1a696d89f4eedd6cc6)
…tent-function-scoping (cherry picked from commit 24db8933d401c73da3bb4413a97f07af1837e5ab)
- Move function 'newIconStyleConfiguration' to the outer scope unicorn/consistent-function-scoping - Move function 'newShapeConfiguration' to the outer scope unicorn/consistent-function-scoping - Move function 'expectSize' to the outer scope unicorn/consistent-function-scoping (cherry picked from commit 900a6dbe7658f2f10d079886377e96bc814c3c94)
- Move function 'getShapeDirectory' to the outer scope unicorn/consistent-function-scoping - Move function 'getEdgeDirectory' to the outer scope unicorn/consistent-function-scoping - Move function 'getShapeDirectory' to the outer scope unicorn/consistent-function-scoping (cherry picked from commit 831c8eafcff57500b772e44f4b8c33e4c2105400)
… scope unicorn/consistent-function-scoping (cherry picked from commit 62f3e25ff9c5444e0d1c592db4053c2b0f877944)
…nsistent-function-scoping (cherry picked from commit 2d21603cb3f19d792e47148bfb0694da780ada40)
csouchet
force-pushed
the
2742-add_unicorn/consistent-function-scoping_rule
branch
from
5a8b86e
to
1f90bed
Compare
csouchet
removed
the
depends on another PR ⚠️
|
Kudos, SonarCloud Quality Gate passed!
|
csouchet
deleted the
2742-add_unicorn/consistent-function-scoping_rule
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid to have to many changes by enabling plugin:unicorn/recommended, I choose to enable some rule one-by-one.
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/consistent-function-scoping.md
Part of #2824
Covers #2742