chore(eslint): add unicorn/prefer-spread rule
#2878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csouchet
added
chore
|
♻️ PR Preview 146d084 has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
|
♻️ PR Preview 146d084 has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
csouchet
force-pushed
the
2742-add_unicorn/prefer-spread_rule
branch
6 times, most recently
from
d0dcb42
to
ba09dd0
Compare
csouchet
force-pushed
the
2742-add_unicorn/prefer-spread_rule
branch
from
035e723
to
b5684bb
Compare
csouchet
removed
the
depends on another PR ⚠️
tbouffard
reviewed
Sep 26, 2023
src/component/helpers/array-utils.ts
Outdated
| @@ -55,10 +55,13 @@ export function ensureIsArray<T>(elements: (T | string)[] | T | string, acceptEm | |||
| export function filter<T extends string>(arrayToFilter: T[], suffix: string, options?: FilterParameter): T[] { | |||
| let pattern = ''; | |||
| if (options?.startingWith) { | |||
| // eslint-disable-next-line unicorn/prefer-spread -- pattern is a string not an array | |||
There was a problem hiding this comment.
I don't understand why the rule detects it as string.concat and not array.concat. If so, it is a bug in the rule
I am testing this locally
There was a problem hiding this comment.
tbouffard
reviewed
Sep 26, 2023
| const orderedFlowNodeBpmnTypes: BpmnSemanticType[] = [ | ||
| 'adHocSubProcess', | ||
| 'transaction', | ||
| // specific management for adhoc and transaction sub-processes which are handled with a dedicated ShapeBpmnSubProcessKind |
There was a problem hiding this comment.
suggestion: move this line above the first "sub-process" values
Currently, the comment is written after these values which make things hard to understand IMHO.
tbouffard
reviewed
Sep 26, 2023
Co-authored-by: Thomas Bouffard <[email protected]>
csouchet
commented
Sep 26, 2023
|
Kudos, SonarCloud Quality Gate passed! |
tbouffard
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid to have to many changes by enabling plugin:unicorn/recommended, I choose to enable some rule one-by-one.
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/prefer-spread.md
Part of #2824
Covers #2742