Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(eslint): add @typescript-eslint/dot-notation rule #2914

Merged
merged 3 commits into from
Oct 6, 2023

Conversation

csouchet
Copy link
Member

@csouchet csouchet commented Oct 5, 2023

https://eslint.org/docs/latest/rules/dot-notation

Part of https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/src/configs/stylistic-type-checked.ts

As there is to many changes and errors to fix with stylistic-type-checked eslint rules, we don't want to implement it.
But the @typescript-eslint/dot-notation rule allows the simplification of the code and the reading.

Covers #2742

@csouchet csouchet added the chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) label Oct 5, 2023
@github-actions
Copy link

github-actions bot commented Oct 5, 2023

♻️ PR Preview 157d767 has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

@github-actions
Copy link

github-actions bot commented Oct 5, 2023

♻️ PR Preview 157d767 has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

@csouchet csouchet marked this pull request as ready for review October 5, 2023 15:31
@sonarcloud
Copy link

sonarcloud bot commented Oct 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@csouchet csouchet enabled auto-merge (squash) October 6, 2023 12:35
@csouchet csouchet merged commit cc8158f into master Oct 6, 2023
24 checks passed
@csouchet csouchet deleted the 2742-add_@typescript-eslint_dot-notation_rule branch October 6, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants