chore(deps): switch from lodash-es to es-toolkit #3142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> es-toolkit is a state-of-the-art, high-performance JavaScript utility library with a small bundle size and strong type annotations. Advantages for `bpmn-visualization`: - receive more updates - optimize for ESM - better tree-shaking - provide types out of the box (for lodash-es, we needed to use a package provided by DefinitevlyTyped) - provide CommonJS files as well, so we are no longer forced to use a trick as we did for lodash-es in the jest configuration of the integration test (which doesn't provide CommonJS file)
tbouffard
added
dependencies
|
🎊 PR Preview c54c5d5 has been successfully built and deployed to https://process-analytics-bpmn-visualization-js-demo_preview-pr-3142.surge.sh 🕐 Build time: 0.011s
🤖 By surge-preview |
|
🎊 PR Preview c54c5d5 has been successfully built and deployed to https://process-analytics-bpmn-visualization-js-doc_preview-pr-3142.surge.sh 🕐 Build time: 0.012s
🤖 By surge-preview |
Test Suites: 2 passed, 2 total Tests: 10 passed, 10 total Snapshots: 0 total Time: 64.674 s
Test Suites: 2 passed, 2 total Tests: 10 passed, 10 total Snapshots: 0 total Time: 61.914 s, estimated 64 s
csouchet
approved these changes
Aug 26, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Advantages for
bpmn-visualization:The performance tests were run on Ubuntu 22.
They include results for master a5886d1 and for switching to es-toolkit.
Notes
For information about the
lodash-esintroduction inbpmn-visualization, see #2678Bundle size decrease
bpmn-visualization.min.jssize decrease: 2887b / 2.82kbefc35ad (latest available commit GH Actions run at the time of the PR creation)
https://github.com/process-analytics/bpmn-visualization-js/actions/runs/10348508718
Rollup decrease detection
efc35ad
new
Performance tests results
On Ubuntu 22, master a5886d1
No change. Tests are run 5 times for each commit.
Notice that lodash/es-toolkit are not involved in the "load" tests
Resources
https://github.com/toss/es-toolkit
https://es-toolkit.slash.page/performance.html (but no figures about the throttle/debounce functions we are using)