refactor: simplify some code using the mxGraph API #3153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`CoordinatesTranslator`: remove extra null check `buildParameter`: shape properties are assumed to be set by the CellRender, according to the cell style. So only use properties for the shape style. NOTE: we have a large number of tests, very varied, so they would have detected regressions in code changes if there were any.
tbouffard
added
refactoring
|
🎊 PR Preview 1fba28f has been successfully built and deployed to https://process-analytics-bpmn-visualization-js-doc_preview-pr-3153.surge.sh 🕐 Build time: 0.011s
🤖 By surge-preview |
|
🎊 PR Preview 1fba28f has been successfully built and deployed to https://process-analytics-bpmn-visualization-js-demo_preview-pr-3153.surge.sh 🕐 Build time: 0.01s
🤖 By surge-preview |
tbouffard
commented
Aug 23, 2024
csouchet
approved these changes
Aug 26, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CoordinatesTranslator: remove extra null checkbuildParameter: shape properties are assumed to be set by the CellRender, according to the cell style. So only use properties for the shape style.NOTE: we have a large number of tests, very varied, so they would have detected regressions in code changes if there were any.