Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps-dev): bump the lint group across 1 directory with 7 updates #3181

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

chore(deps-dev): bump the lint group across 1 directory with 7 updates #3181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad7cab8
chore(deps-dev): bump the lint group across 1 directory with 7 updates
dependabot[bot] Oct 8, 2024
4fe957c
lint
csouchet Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dev/ts/pages/diagram-navigation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ function configureZoomDebounceInput(parameters: URLSearchParams): HTMLInputEleme
}

function start(): void {
const parameters = new URLSearchParams(window.location.search);
const parameters = new URLSearchParams(globalThis.location.search);
configureMousePointer(parameters);
configureControlsPanel(parameters);

Expand Down
2 changes: 1 addition & 1 deletion dev/ts/pages/overlays.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ function configureRemoveAllOverlays(): void {
}

function start(): void {
const parameters = new URLSearchParams(window.location.search);
const parameters = new URLSearchParams(globalThis.location.search);
configureMousePointer(parameters);
configureControlsPanel(parameters);

Expand Down
2 changes: 1 addition & 1 deletion dev/ts/shared/internal-helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export function logStartup(message?: string, ...optionalParameters: unknown[]):

export function logErrorAndOpenAlert(error: string, alertMessage?: string): void {
logError(error);
window.alert(alertMessage ?? error);
globalThis.alert(alertMessage ?? error);
}

export function logError(error: string): void {
Expand Down
4 changes: 2 additions & 2 deletions dev/ts/shared/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,10 +269,10 @@
if ([...parameters.keys()].some(key => key.startsWith('style.api.'))) {
style = { stroke: {}, font: {}, fill: {} };

parameters.get('style.api.stroke.color') && (style.stroke.color = parameters.get('style.api.stroke.color'));

Check failure on line 272 in dev/ts/shared/main.ts

View workflow job for this annotation

GitHub Actions / build (ubuntu-22.04, -- --coverage) 

Expected an assignment or function call and instead saw an expression

Check failure on line 272 in dev/ts/shared/main.ts

View workflow job for this annotation

GitHub Actions / build (macos-13) 

Expected an assignment or function call and instead saw an expression

Check failure on line 272 in dev/ts/shared/main.ts

View workflow job for this annotation

GitHub Actions / build (windows-2022) 

Expected an assignment or function call and instead saw an expression

parameters.get('style.api.font.color') && (style.font.color = parameters.get('style.api.font.color'));

Check failure on line 274 in dev/ts/shared/main.ts

View workflow job for this annotation

GitHub Actions / build (ubuntu-22.04, -- --coverage) 

Expected an assignment or function call and instead saw an expression

Check failure on line 274 in dev/ts/shared/main.ts

View workflow job for this annotation

GitHub Actions / build (macos-13) 

Expected an assignment or function call and instead saw an expression

Check failure on line 274 in dev/ts/shared/main.ts

View workflow job for this annotation

GitHub Actions / build (windows-2022) 

Expected an assignment or function call and instead saw an expression
parameters.get('style.api.font.opacity') && (style.font.opacity = Number(parameters.get('style.api.font.opacity')));

Check failure on line 275 in dev/ts/shared/main.ts

View workflow job for this annotation

GitHub Actions / build (ubuntu-22.04, -- --coverage) 

Expected an assignment or function call and instead saw an expression

Check failure on line 275 in dev/ts/shared/main.ts

View workflow job for this annotation

GitHub Actions / build (macos-13) 

Expected an assignment or function call and instead saw an expression

Check failure on line 275 in dev/ts/shared/main.ts

View workflow job for this annotation

GitHub Actions / build (windows-2022) 

Expected an assignment or function call and instead saw an expression

if (parameters.get('style.api.fill.color')) {
style.fill.color = parameters.get('style.api.fill.color');
Expand All @@ -283,7 +283,7 @@
direction: parameters.get('style.api.fill.color.direction') as GradientDirection,
} as FillColorGradient;
}
parameters.get('style.api.fill.opacity') && (style.fill.opacity = Number(parameters.get('style.api.fill.opacity')));

Check failure on line 286 in dev/ts/shared/main.ts

View workflow job for this annotation

GitHub Actions / build (ubuntu-22.04, -- --coverage) 

Expected an assignment or function call and instead saw an expression

Check failure on line 286 in dev/ts/shared/main.ts

View workflow job for this annotation

GitHub Actions / build (macos-13) 

Expected an assignment or function call and instead saw an expression

Check failure on line 286 in dev/ts/shared/main.ts

View workflow job for this annotation

GitHub Actions / build (windows-2022) 

Expected an assignment or function call and instead saw an expression

logStartup(`Prepared "Update Style" API object`, style);
} else {
Expand All @@ -309,18 +309,18 @@
const log = logStartup;
log(`Initializing BpmnVisualization with container:`, config.globalOptions.container);

const parameters = new URLSearchParams(window.location.search);
const parameters = new URLSearchParams(globalThis.location.search);
const rendererIgnoreBpmnColors = parameters.get('renderer.ignore.bpmn.colors');
if (rendererIgnoreBpmnColors) {
const ignoreBpmnColors = rendererIgnoreBpmnColors === 'true';
log('Ignore support for "BPMN in Color"?', ignoreBpmnColors);
!config.globalOptions.renderer && (config.globalOptions.renderer = {});

Check failure on line 317 in dev/ts/shared/main.ts

View workflow job for this annotation

GitHub Actions / build (ubuntu-22.04, -- --coverage) 

Expected an assignment or function call and instead saw an expression

Check failure on line 317 in dev/ts/shared/main.ts

View workflow job for this annotation

GitHub Actions / build (macos-13) 

Expected an assignment or function call and instead saw an expression

Check failure on line 317 in dev/ts/shared/main.ts

View workflow job for this annotation

GitHub Actions / build (windows-2022) 

Expected an assignment or function call and instead saw an expression
config.globalOptions.renderer.ignoreBpmnColors = ignoreBpmnColors;
}

bpmnVisualization = new ThemedBpmnVisualization(config.globalOptions);
log('Initialization completed');
new DropFileUserInterface(window, 'drop-container', bpmnVisualization.graph.container, readAndLoadFile);
new DropFileUserInterface(globalThis, 'drop-container', bpmnVisualization.graph.container, readAndLoadFile);

Check failure on line 323 in dev/ts/shared/main.ts

View workflow job for this annotation

GitHub Actions / demo_preview 

Argument of type 'typeof globalThis' is not assignable to parameter of type 'Window'.
log('Drag&Drop support initialized');

statusKoNotifier = config.statusKoNotifier ?? logOnlyStatusKoNotifier;
Expand Down
Loading
Loading