Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use styled-components in KeyboardShortcutModal #2356

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

lindapaiste
Copy link
Collaborator

Progress on #1760

Changes:

  • Migrate styles from client/styles/components/_keyboard-shortcuts.scss into individual styled components in the client/modules/IDE/components/KeyboardShortcutModal.jsx file (Container, Command, etc.).
  • Moved around some paddings and margins to minimize complex selectors.
  • Moved two untranslated strings into the translations/locales/en-US/translations.json file.
  • Created a Shortcut component to be used for each item to minimize repetitive markup.
  • Looks identical to before, at least for me on Windows Chrome.

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

Copy link
Contributor

@PiyushChandra17 PiyushChandra17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely Done 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants