Convert Collection to a function component
#2366
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lindapaiste
changed the title
Collection to a function component
24 tasks
# Conflicts: # client/modules/User/components/Collection.jsx
lindapaiste
commented
Mar 5, 2024
Comment on lines
+113
to
+123
| collection: PropTypes.shape({ | ||
| id: PropTypes.string, | ||
| name: PropTypes.string, | ||
| slug: PropTypes.string, | ||
| description: PropTypes.string, | ||
| owner: PropTypes.shape({ | ||
| username: PropTypes.string | ||
| }).isRequired, | ||
| items: PropTypes.arrayOf(PropTypes.shape({})) | ||
| }).isRequired, | ||
| isOwner: PropTypes.bool.isRequired |
There was a problem hiding this comment.
@raclim it seemed like it made sense to pass down the collection object from the parent component since the parent already has the object. But I find these prop types super annoying so idk, I may roll back some of the changes in the CollectionMetadata file and access the collection with the useSelector.
There was a problem hiding this comment.
That makes sense, it is pretty long! Thanks for the heads up!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress on #2358
Merge after #2253
Changes:
Collectionto a function component.I have verified that this pull request:
npm run lint)npm run test)developbranch.Fixes #123