Lazily read lines in ts_file_server #45
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I kind of like the idea. While working #237 to make While this might have a slight impact on access, I don't think this is a big problem. The current eager loading of largish files poses a bigger problem. A 100MB file currently causes memory spikes up to 900-1000MB. What do you think about that, @nniclausse? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows tsung to use a very large file as a variable source; each read will seek to an arbitrary location in the file and perform a read.
It's possible (likely, even) that this change will reduce performance of the variable sourcing feature; I can imagine using a config flag to enable it, perhaps. FWIW I haven't observed a serious degradation of performance in my usage.
Usage remains identical.