Skip to content

Commit

Permalink
Fix tests
Browse files Browse the repository at this point in the history
  • Loading branch information
andrii-vysotskyi-cko committed Oct 10, 2024
1 parent 08f45be commit cb24172
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ final class UrlSessionHttpConnectorTests: XCTestCase {
// Given
let codingError = NSError(domain: "", code: 1234)
requestMapper.urlRequestFromClosure = {
throw HttpConnectorFailure.encoding(codingError)
throw HttpConnectorFailure(code: .encoding, underlyingError: codingError)
}

// When
Expand All @@ -44,8 +44,8 @@ final class UrlSessionHttpConnectorTests: XCTestCase {
)

// Then
if let failure = error as? HttpConnectorFailure, case .encoding(let encodingError) = failure {
XCTAssertEqual(encodingError as NSError, codingError)
if let failure = error as? HttpConnectorFailure, case .encoding = failure.code {
XCTAssertEqual(failure.underlyingError as NSError?, codingError)
return
}
XCTFail("Unexpected result")
Expand All @@ -66,7 +66,7 @@ final class UrlSessionHttpConnectorTests: XCTestCase {
)

// Then
if let failure = error as? HttpConnectorFailure, case .networkUnreachable = failure {
if let failure = error as? HttpConnectorFailure, case .networkUnreachable = failure.code {
return
}
XCTFail("Unexpected result")
Expand All @@ -85,7 +85,7 @@ final class UrlSessionHttpConnectorTests: XCTestCase {
)

// Then
if let failure = error as? HttpConnectorFailure, case .internal = failure {
if let failure = error as? HttpConnectorFailure, case .internal = failure.code {
return
}
XCTFail("Expected internal failure")
Expand All @@ -107,7 +107,7 @@ final class UrlSessionHttpConnectorTests: XCTestCase {
)

// Then
if case let failure = error as? HttpConnectorFailure, case .decoding = failure {
if let failure = error as? HttpConnectorFailure, case .decoding = failure.code {
return
}
XCTFail("Unexpected result")
Expand All @@ -130,7 +130,7 @@ final class UrlSessionHttpConnectorTests: XCTestCase {
)

// Then
if case let failure = error as? HttpConnectorFailure, case .decoding = failure {
if let failure = error as? HttpConnectorFailure, case .decoding = failure.code {
return
}
XCTFail("Unexpected result")
Expand All @@ -153,7 +153,7 @@ final class UrlSessionHttpConnectorTests: XCTestCase {
)

// Then
if case let failure = error as? HttpConnectorFailure, case .decoding = failure {
if let failure = error as? HttpConnectorFailure, case .decoding = failure.code {
return
}
XCTFail("Unexpected result")
Expand All @@ -176,7 +176,7 @@ final class UrlSessionHttpConnectorTests: XCTestCase {
)

// Then
if let failure = error as? HttpConnectorFailure, case let .server(serverError, statusCode) = failure {
if let failure = error as? HttpConnectorFailure, case let .server(serverError, statusCode) = failure.code {
XCTAssertEqual(serverError.errorType, "card.invalid-number")
XCTAssertEqual(statusCode, 404)
} else {
Expand Down Expand Up @@ -224,7 +224,7 @@ final class UrlSessionHttpConnectorTests: XCTestCase {

// Then
let error = await assertThrowsError(try await task.value)
if case let failure = error as? HttpConnectorFailure, case .cancelled = failure {
if let failure = error as? HttpConnectorFailure, case .cancelled = failure.code {
return
}
XCTFail("Unexpected result")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,11 @@ final class DefaultThreeDSServiceTests: XCTestCase {
encoder.outputFormatting = .sortedKeys
webSession = MockWebAuthenticationSession()
sut = DefaultCustomerActionsService(
decoder: JSONDecoder(), encoder: encoder, jsonWritingOptions: [.sortedKeys], webSession: webSession
decoder: JSONDecoder(),
encoder: encoder,
jsonWritingOptions: [.sortedKeys],
webSession: webSession,
logger: .stub
)
threeDSService = Mock3DS2Service()
}
Expand Down

0 comments on commit cb24172

Please sign in to comment.