Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ad-hoc): prepare ProcessOut target for Swift 6 #368

Merged
merged 25 commits into from
Oct 15, 2024
Merged

feat(ad-hoc): prepare ProcessOut target for Swift 6 #368

merged 25 commits into from
Oct 15, 2024

Conversation

andrii-vysotskyi-cko
Copy link
Collaborator

@andrii-vysotskyi-cko andrii-vysotskyi-cko commented Oct 14, 2024 •
edited
Loading

Description

  • Ensure ProcessOut target is safe to use in concurrent environment
    • Legacy and UI is left unchanged
    • ApplePay functionality is isolated to MainActor as PassKit entities are not Sendable
  • Replace POImmutableExcludedCodable with sourcery generated AutoCodingKeys
  • Simplify AutoCompletion template
  • Deprecate completion-based service methods

Jira Issue

-

@andrii-vysotskyi-cko andrii-vysotskyi-cko marked this pull request as ready for review October 15, 2024 11:13
@andrii-vysotskyi-cko andrii-vysotskyi-cko merged commit e884978 into master Oct 15, 2024
3 checks passed
@andrii-vysotskyi-cko andrii-vysotskyi-cko deleted the feat/prepare-processout-target-for-swift-6 branch October 15, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitalii-vanziak-cko vitalii-vanziak-cko vitalii-vanziak-cko approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrii-vysotskyi-cko @vitalii-vanziak-cko