-
-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add params support for aliases #1900
Add params support for aliases #1900
Conversation
Cool feature! This seems to remove support to use alias a a quick way to write messages or your tatus and so on. I think users most likely will use this feature and it shouldn't be dropped. Most importantly if such a feature is dropped it should be mentioned in the commit message :) I know this arguments parsing is quite annoying stuff. I even believe we have this in more commands (the task/question on how to deal with spaces and ""). Do you think you could rewrite this PR to support parameters but still support the old behaviour? Some ideas:
|
it does not drop support, just "away" command is gone now. You don't need to use quotes, it works the same as before, also it supports quotes for params |
Ahh great! As mentioned I was not sure about it since I was quite tired last night. I will take a look deeper now.
It moved to /status set away. Would be great if you could adapt this. |
Before aliases used spaces in their name, now the alias part is being read only before the first space, thus allowing execution of complex command with aliases. Example (with plugin): `/alias add echo "/system exec echo"` will allow execution of `/echo test` as opposed to prior state when the Profanity will search for alias "echo tests" and output `Unknown command: /echo test` Minor change: removed an example with invalid command (`/away`)
7bd12ea
to
9ecade9
Compare
See description
How to test the functionality
/alias add m /msg
use alias like a normal command (
/m friend Hello!
)