Allow redirects for /plugins install and add emptiness check for downloaded files
#1922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
H3rnand3zzz
changed the title
/plugins install follow redirect
H3rnand3zzz
changed the title
/plugins install follow redirect/plugins install and add emptiness check for downloaded files
Fix profanity-im#1901 Suggested by @jubalh
Empty file is not a normal condition for file downloading, thus user has to be notifed. Related to profanity-im#1901
H3rnand3zzz
force-pushed
the
fix/plugins-install-follow-redirect
branch
from
ef69486 to
092b553
Compare
jubalh
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to test the functionality
Use
/plugins install <redirect_link>, e.g./plugins install https://github.com/profanity-im/profanity-plugins/raw/master/stable/syscmd.pyTo test emptiness check, I would suggest finding some empty file that ends up with
.cor.pyfor the purpose of testing.Fix #1901