Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not check for unique stanza-id for MAM messages #1926

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Do not check for unique stanza-id for MAM messages #1926

merged 1 commit into from
Nov 13, 2023

Conversation

H3rnand3zzz
Copy link
Contributor

See commit message for details.

Fix #1925

@jubalh
Copy link
Member

jubalh commented Nov 13, 2023

I wouldn't write [Fix Duplicate stanza-id errors flood for MAM](https://github.com/profanity-im/profanity/pull/1926/commits/44d72e3b226462217576879b15dd0463beb9f4b5) as the commit header since this is just what fixes 1925. But not what this change is really about. I would write:

Do not check for unique stanza-id in case of MAM message

Since we might have MAM messages already received earlier it doesn't make sense to require unique stanza-ids there.
Fix https://github.com/profanity-im/profanity/issues/1925.

jubalh
jubalh requested changes Nov 13, 2023
View reviewed changes
Copy link
Member

@jubalh jubalh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please change commit message

@jubalh jubalh added this to the next milestone Nov 13, 2023
@H3rnand3zzz
Do not check for unique stanza-id for MAM messages
d3566b1 
Since we might have MAM messages already received earlier
it doesn't make sense to require unique stanza-ids there.
Fix profanity-im#1925.
@H3rnand3zzz H3rnand3zzz force-pushed the fix/mam-dupe-stanza-id-flood branch from 44d72e3 to d3566b1 Compare November 13, 2023 08:35
@H3rnand3zzz
Copy link
Contributor Author

please change commit message

done

@H3rnand3zzz H3rnand3zzz changed the title Fix Duplicate stanza-id errors flood for MAM Do not check for unique stanza-id for MAM messages Nov 13, 2023
@jubalh jubalh merged commit 740c209 into profanity-im:master Nov 13, 2023
6 checks passed
@H3rnand3zzz H3rnand3zzz deleted the fix/mam-dupe-stanza-id-flood branch November 13, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jubalh jubalh jubalh approved these changes

Assignees

@H3rnand3zzz H3rnand3zzz

Labels
improvement
Projects
None yet
Milestone
next
Development

Successfully merging this pull request may close these issues.

Duplicate stanza-id warning for every message.
2 participants
@H3rnand3zzz @jubalh