Logic initialisation + TG bot addition (#3) #5

Wudext · 2023-04-10T11:06:37Z

No description provided.

ping api finals + partial service impl NOT TESTED

not tested)

get_fetcher impl done scheduler impl done todo: upd timing on fail, impl for alerts, tg bot as an endpoint

… into ping

github-actions · 2023-04-13T10:29:55Z

✅ Result of Pytest Coverage

---------- coverage: platform linux, python 3.10.11-final-0 ----------

Name	Stmts	Miss	Cover
aciniformes_backend/init.py	0	0	100%
aciniformes_backend/main.py	4	4	0%
aciniformes_backend/models/init.py	5	0	100%
aciniformes_backend/models/alerts.py	19	0	100%
aciniformes_backend/models/base.py	8	0	100%
aciniformes_backend/models/fetcher.py	18	0	100%
aciniformes_backend/models/metric.py	9	0	100%
aciniformes_backend/routes/init.py	1	0	100%
aciniformes_backend/routes/alert/init.py	0	0	100%
aciniformes_backend/routes/alert/alert.py	43	0	100%
aciniformes_backend/routes/alert/reciever.py	53	0	100%
aciniformes_backend/routes/base.py	13	0	100%
aciniformes_backend/routes/fetcher.py	52	0	100%
aciniformes_backend/routes/mectric.py	35	0	100%
aciniformes_backend/serivce/init.py	3	0	100%
aciniformes_backend/serivce/alert.py	28	1	96%
aciniformes_backend/serivce/base.py	47	12	74%
aciniformes_backend/serivce/bootstrap.py	28	0	100%
aciniformes_backend/serivce/exceptions.py	15	4	73%
aciniformes_backend/serivce/fake.py	86	0	100%
aciniformes_backend/serivce/fetcher.py	28	2	93%
aciniformes_backend/serivce/metric.py	18	1	94%
aciniformes_backend/serivce/receiver.py	29	1	97%
aciniformes_backend/settings.py	14	0	100%
TOTAL	556	25	96%
=======================	50	passed,	15

grigoriev-semyon

Пробежался по коду, очень много комментариев, так что оставлю в общем формате пунктов, которые надо исправить

Очень много кода, который остался от предыдущих версий и больше не используется
async/await используется очень плохо - в тех местах где он замедляет - он есть, а в тех где он нужен по логике - его нет
Нет документации
Проект сделан не по шаблону
Отсутствует докерфайл и прочие плюшки шаблонизации

aciniformes_backend/routes/alert/alert.py

aciniformes_backend/routes/alert/reciever.py

github-actions · 2023-07-11T08:28:43Z

💩 Code linting failed, use black and isort to fix it.

grigoriev-semyon

ping'а нет, как будет - досмотрю

.idea/aciniformes-project.iml

.idea/workspace.xml

aciniformes_backend/routes/alert/alert.py

grigoriev-semyon

миграции куда то пропали
тесты падают
нет докерфайла для пингера

github-actions · 2023-07-22T21:29:51Z

💩 Code linting failed, use black and isort to fix it.

github-actions · 2023-07-23T15:54:40Z

💩 Code linting failed, use black and isort to fix it.

добавил логгинг

Temmmmmo

Описание к ПРу

aciniformes_backend/routes/alert/alert.py

aciniformes_backend/routes/alert/reciever.py

aciniformes_backend/routes/fetcher.py

aciniformes_backend/serivce/alert.py

migrations/versions/febba504289a_init.py

parfenovma and others added 16 commits February 3, 2023 23:36

ping service initial

f8e97b9

daily wtf commit

ab12c94

ping api finals + partial service impl NOT TESTED

alert pipeline initial

6cf5c64

not tested)

fixes

aadfa1d

add_metric impl done

4513377

get_fetcher impl done scheduler impl done todo: upd timing on fail, impl for alerts, tg bot as an endpoint

change delay on alert impl

61d73e6

admin creds in dotenv

e232430

ping tests initial

3042561

ping api tests complete

76593ed

scheduler service tests initial

91a2de1

Implimenting authlib

fe484f5

Deleting __pycache__

80dab9a

Update requirements.txt

caef12d

Merge branch 'ping' of https://github.com/profcomff/aciniformes-project…

f5bc0f4

… into ping

Test fix

7142f36

Update requirements.dev.txt

a10b8b3

Wudext added 9 commits April 17, 2023 14:59

TG Bot logic initialisation (kinda) + scheduler logic fix

c8b7f2a

I don`t know what im doing

94b66d1

OMFG it`s working

c058235

Fixing tests

62ee349

Fix migrations

931db77

Cleaning up

dd8fc4d

Fixing tests (not realy) + adding README.md

c236e4b

Finishing tests

2440236

Fix test

e3350d2

dyakovri self-requested a review May 8, 2023 16:19

dyakovri linked an issue May 8, 2023 that may be closed by this pull request

Доделать алертинг, счедулер (пингер) #3

Closed

grigoriev-semyon self-requested a review May 9, 2023 09:31

grigoriev-semyon requested changes May 14, 2023

View reviewed changes

Wudext added 2 commits July 11, 2023 11:27

Check for addition/deletion while working

cb41ea8

Black + Isort (again блять)

a211f88

Wudext added 2 commits July 11, 2023 11:36

Pydantic 2 + fix requirements.txt

2f4d7cb

Fix migrations

6b87bba

grigoriev-semyon requested changes Jul 12, 2023

View reviewed changes

.idea/aciniformes-project.iml Outdated Show resolved Hide resolved

.idea/workspace.xml Outdated Show resolved Hide resolved

aciniformes_backend/routes/alert/alert.py Outdated Show resolved Hide resolved

grigoriev-semyon requested changes Jul 12, 2023

View reviewed changes

Wudext and others added 5 commits July 15, 2023 19:47

Delete .idea directory

eb079da

Alert and Receiver schema fix + test fix

5be400e

Dockerfile for pinger + ping fix + update requirements.txt

0512d88

Dockerfile fix + local startup fix

d17dbd2

начало моей работы над этой помойкой

71237da

фикс тестов

cb28f3a

grigoriev-semyon added 2 commits July 23, 2023 19:01

lint

ca789a1

добавил фетч фетчеров поо расписанию

7bef0c4

добавил логгинг

grigoriev-semyon linked an issue Jul 23, 2023 that may be closed by this pull request

Перейти на Pydantic v2 в aciniformes-project #6

Closed

grigoriev-semyon added 5 commits July 23, 2023 23:37

пофиксил пинг

ea64080

loop sigint handler

052e73c

crud service del

0ce30a3

async

7959f58

async

7e1e425

Temmmmmo reviewed Jul 24, 2023

View reviewed changes

review

14754b6

grigoriev-semyon requested a review from Temmmmmo July 27, 2023 13:30

Temmmmmo approved these changes Jul 27, 2023

View reviewed changes

grigoriev-semyon approved these changes Jul 27, 2023

View reviewed changes

grigoriev-semyon merged commit 06d8a7d into init Jul 27, 2023
2 checks passed

grigoriev-semyon deleted the ping branch July 27, 2023 13:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Logic initialisation + TG bot addition (#3) #5

Logic initialisation + TG bot addition (#3) #5

Wudext commented Apr 10, 2023

github-actions bot commented Apr 13, 2023 •

edited

Loading

grigoriev-semyon left a comment

github-actions bot commented Jul 11, 2023

grigoriev-semyon left a comment

grigoriev-semyon left a comment

github-actions bot commented Jul 22, 2023

github-actions bot commented Jul 23, 2023

Temmmmmo left a comment

Logic initialisation + TG bot addition (#3) #5

Logic initialisation + TG bot addition (#3) #5

Conversation

Wudext commented Apr 10, 2023

github-actions bot commented Apr 13, 2023 • edited Loading

✅ Result of Pytest Coverage

grigoriev-semyon left a comment

Choose a reason for hiding this comment

github-actions bot commented Jul 11, 2023

grigoriev-semyon left a comment

Choose a reason for hiding this comment

grigoriev-semyon left a comment

Choose a reason for hiding this comment

github-actions bot commented Jul 22, 2023

github-actions bot commented Jul 23, 2023

Temmmmmo left a comment

Choose a reason for hiding this comment

github-actions bot commented Apr 13, 2023 •

edited

Loading