flag config error if admissionGP exceeds warmupGP (#278)

project-codeflare · Dec 13, 2024 · b6bd577 · b6bd577
1 parent 515c0a3
commit b6bd577
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/pkg/config/config.go b/pkg/config/config.go
@@ -143,7 +143,11 @@ func ValidateAppWrapperConfig(config *AppWrapperConfig) error {
 			config.FaultTolerance.AdmissionGracePeriod, config.FaultTolerance.GracePeriodMaximum)
 	}
 	if config.FaultTolerance.WarmupGracePeriod > config.FaultTolerance.GracePeriodMaximum {
-		return fmt.Errorf("WarmupGracePeriod %v exceeds GracePeriodCeiling %v",
+		return fmt.Errorf("AdmissionGracePeriod %v exceeds GracePeriodCeiling %v",
+			config.FaultTolerance.WarmupGracePeriod, config.FaultTolerance.GracePeriodMaximum)
+	}
+	if config.FaultTolerance.AdmissionGracePeriod > config.FaultTolerance.WarmupGracePeriod {
+		return fmt.Errorf("AdmissionGracePeriod %v exceeds AdmissionGracePeriod %v",
 			config.FaultTolerance.WarmupGracePeriod, config.FaultTolerance.GracePeriodMaximum)
 	}
 	if config.FaultTolerance.SuccessTTL <= 0 {

diff --git a/pkg/config/config_test.go b/pkg/config/config_test.go
@@ -56,6 +56,9 @@ var _ = Describe("AppWrapper Config", func() {
 		bad = &FaultToleranceConfig{WarmupGracePeriod: 10 * time.Second, GracePeriodMaximum: 1 * time.Second}
 		Expect(ValidateAppWrapperConfig(&AppWrapperConfig{FaultTolerance: bad})).ShouldNot(Succeed())
 
+		bad = &FaultToleranceConfig{AdmissionGracePeriod: 10 * time.Second, WarmupGracePeriod: 1 * time.Second}
+		Expect(ValidateAppWrapperConfig(&AppWrapperConfig{FaultTolerance: bad})).ShouldNot(Succeed())
+
 		bad = &FaultToleranceConfig{SuccessTTL: -1 * time.Second}
 		Expect(ValidateAppWrapperConfig(&AppWrapperConfig{FaultTolerance: bad})).ShouldNot(Succeed())
 	})