Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure head #354

Merged
merged 2 commits into from
Sep 25, 2023
Merged

Configure head #354

merged 2 commits into from
Sep 25, 2023

Conversation

MichaelClifford
Copy link
Collaborator

Issue link

closes #190

What changes have been made

Adds head_cpus, head_memory and head_gpus to ClusterConfig so that the head resources can also be configured by the user.

Verification steps

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@MichaelClifford MichaelClifford requested review from Maxusmusti and Bobbins228 and removed request for anishasthana and dimakis September 24, 2023 20:32
Bobbins228
Bobbins228 approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@Bobbins228 Bobbins228 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried this out on an OpenShift Cluster and everything works as expected. Resource requests are changed to the "head" values I specify. Nice work Michael
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2023
Maxusmusti
Maxusmusti approved these changes Sep 25, 2023
View reviewed changes
Copy link
Collaborator

@Maxusmusti Maxusmusti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobbins228, Maxusmusti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2023
@openshift-merge-robot openshift-merge-robot merged commit 54a5a12 into project-codeflare:main Sep 25, 2023
3 checks passed
@MichaelClifford MichaelClifford mentioned this pull request Sep 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Maxusmusti Maxusmusti Maxusmusti approved these changes

@Bobbins228 Bobbins228 Bobbins228 approved these changes

Assignees

@Maxusmusti Maxusmusti

@Bobbins228 Bobbins228

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ray cluster headgroup resources
4 participants
@MichaelClifford @Maxusmusti @Bobbins228 @openshift-merge-robot