Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Altered demo notebooks for Kueue default & mTLS default #486

Merged
merged 12 commits into from
Apr 25, 2024
Merged

Altered demo notebooks for Kueue default & mTLS default #486

merged 12 commits into from
Apr 25, 2024

Conversation

Bobbins228
Copy link
Contributor

@Bobbins228 Bobbins228 commented Mar 21, 2024 •
edited
Loading

Issue link

RHOAIENG-1913

What changes have been made

Updated existing notebooks to use Kueue by default and have notes for setup.
Removed mention of local_interactive
Removed InstaScale NB and mentions of MCAD from other NBs

Verification steps

Run the demo notebook when #470

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@Bobbins228 Bobbins228 added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 21, 2024
@Bobbins228 Bobbins228 force-pushed the kueue-notebook branch 3 times, most recently from 1b3d273 to 0ce4a79 Compare April 5, 2024 16:15
@Bobbins228 Bobbins228 removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 5, 2024
@Bobbins228 Bobbins228 changed the title Added demo notebook for Kueue by default Altered demo notebooks for Kueue default & mTLS default Apr 24, 2024
@ChughShilpa ChughShilpa self-requested a review April 24, 2024 12:51
Fiona-Waters
Fiona-Waters reviewed Apr 24, 2024
View reviewed changes
Copy link
Contributor

@Fiona-Waters Fiona-Waters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently setting up to run some of the notebooks on openshift. Just some comments first. Thanks @Bobbins228

demo-notebooks/additional-demos/hf_interactive.ipynb Outdated Show resolved Hide resolved
demo-notebooks/guided-demos/0_basic_ray.ipynb Outdated Show resolved Hide resolved
demo-notebooks/guided-demos/3_basic_interactive.ipynb Outdated Show resolved Hide resolved
demo-notebooks/guided-demos/3_basic_interactive.ipynb Outdated Show resolved Hide resolved
demo-notebooks/guided-demos/notebook-ex-outputs/2_cluster_job_client.ipynb Outdated Show resolved Hide resolved
demo-notebooks/guided-demos/3_basic_interactive.ipynb Outdated Show resolved Hide resolved
demo-notebooks/additional-demos/local_interactive.ipynb Show resolved Hide resolved
@ChughShilpa
Copy link
Contributor

Just wondering why we are not adding write_to_file parameter in the cluster configuration in any of the demo notebooks.
@Bobbins228

@Bobbins228
Copy link
Contributor Author

Just wondering why we are not adding write_to_file parameter in the cluster configuration in any of the demo notebooks. @Bobbins228

This is because by default we do not write to a file but I could include it with a comment if that sounds like it would be beneficial to new users

Fiona-Waters
Fiona-Waters reviewed Apr 25, 2024
View reviewed changes
Copy link
Contributor

@Fiona-Waters Fiona-Waters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested some of the notebooks on openshift and they work as expected. Just one small comment but otherwise looks great to me. Great work Mark!

demo-notebooks/guided-demos/0_basic_ray.ipynb Outdated Show resolved Hide resolved
ChughShilpa
ChughShilpa approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@ChughShilpa ChughShilpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested some notebooks and it worked as expected

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2024
@Fiona-Waters
Copy link
Contributor

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ChughShilpa, Fiona-Waters

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 87e6f26 into project-codeflare:main Apr 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgrove-oss dgrove-oss dgrove-oss left review comments

@ChristianZaccaria ChristianZaccaria ChristianZaccaria left review comments

@Fiona-Waters Fiona-Waters Fiona-Waters left review comments

@ChughShilpa ChughShilpa ChughShilpa approved these changes

@anishasthana anishasthana Awaiting requested review from anishasthana

@KPostOffice KPostOffice Awaiting requested review from KPostOffice

Assignees

@ChughShilpa ChughShilpa

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Bobbins228 @ChughShilpa @Fiona-Waters @dgrove-oss @KPostOffice @ChristianZaccaria