Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClusterConfiguration parameter that will accept user inputted labels and apply them to the Ray Cluster on creation. #526

Merged
merged 2 commits into from
May 9, 2024

Conversation

Ygnas
Copy link
Contributor

@Ygnas Ygnas commented May 1, 2024

Issue link

RHOAIENG-2017

What changes have been made

Add a ClusterConfiguration parameter that will accept user inputted labels and apply them to the Ray Cluster on creation.

Verification steps

Defining the ClusterConfiguration with 3 labels would generate the RayCluster with those labels + any other ones that are already part of it.

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@Ygnas Ygnas requested a review from Bobbins228 May 1, 2024 08:06
@Ygnas Ygnas changed the title User labels ClusterConfiguration parameter that will accept user inputted labels and apply them to the Ray Cluster on creation. May 1, 2024
@Ygnas Ygnas force-pushed the user-labels branch 2 times, most recently from b18fea0 to 3f10782 Compare May 1, 2024 10:23
@ChristianZaccaria
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 1, 2024
Copy link
Collaborator

@ChristianZaccaria ChristianZaccaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes tested and works as expected:

  • Labels added to the generated RayCluster YAML.
  • On creation, RayCluster CR contains the supplied labels.

src/codeflare_sdk/cluster/cluster.py Outdated Show resolved Hide resolved
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 2, 2024
@ChristianZaccaria
Copy link
Collaborator

/lgtm - needs rebase

@Ygnas
Copy link
Contributor Author

Ygnas commented May 7, 2024

Rebased

@Bobbins228
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 8, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 9, 2024
Copy link
Contributor

@Fiona-Waters Fiona-Waters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran a demo notebook on openshift and it works as expected with the labels being added to the generated yaml and the resulting raycluster instance.
Just a couple of nitpicks but otherwise good to go. Thanks Ignas!

docs/cluster-configuration.md Outdated Show resolved Hide resolved
docs/cluster-configuration.md Outdated Show resolved Hide resolved
Copy link
Contributor

@Fiona-Waters Fiona-Waters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 9, 2024
@Fiona-Waters
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 9, 2024
Copy link
Contributor

openshift-ci bot commented May 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ChristianZaccaria, Fiona-Waters

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 9b49b59 into project-codeflare:main May 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants