Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RHOAIENG-5344 - E2E test for Ray local interactive #532

Merged
merged 1 commit into from
May 22, 2024
Merged

RHOAIENG-5344 - E2E test for Ray local interactive #532

merged 1 commit into from
May 22, 2024

Conversation

jiripetrlik
Copy link
Contributor

@jiripetrlik jiripetrlik requested review from sutaakar and Srihari1192 and removed request for KPostOffice and Fiona-Waters May 9, 2024 21:15
@jiripetrlik jiripetrlik force-pushed the RHOAIENG-5344 branch 2 times, most recently from 063d83a to a3200c9 Compare May 20, 2024 08:21
@jiripetrlik jiripetrlik force-pushed the RHOAIENG-5344 branch 3 times, most recently from aede101 to 4652de5 Compare May 20, 2024 13:43
@sutaakar sutaakar mentioned this pull request May 21, 2024
Merged
4 tasks
@jiripetrlik jiripetrlik force-pushed the RHOAIENG-5344 branch 2 times, most recently from b69f3fd to 3198c61 Compare May 21, 2024 21:22
Srihari1192
Srihari1192 approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@Srihari1192 Srihari1192 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

one nit pick , its good to remove created kueue resources aswell, i see its not handled in other tests too

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 22, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 22, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Srihari1192
Once this PR has been reviewed and has the lgtm label, please assign maxusmusti for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jiripetrlik jiripetrlik merged commit 54e90f5 into project-codeflare:main May 22, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sutaakar sutaakar sutaakar left review comments

@Srihari1192 Srihari1192 Srihari1192 approved these changes

Assignees

@Srihari1192 Srihari1192

Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jiripetrlik @sutaakar @Srihari1192