Workbench certs #544
Merged
Workbench certs #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KPostOffice
force-pushed
the
workbench-certs
branch
from
f0a09a7
to
822660a
Compare
ChristianZaccaria
requested changes
May 23, 2024
There was a problem hiding this comment.
Tested:
- Priority is given to the
ca_cert_pathargument over the environment variable set. - Can authenticate with certificate located through the path specified by the environment variable.
- Ran through a notebook and submitted job successfully.
Thank you, just left a few nitpicks.
KPostOffice
force-pushed
the
workbench-certs
branch
from
822660a
to
b6e27ff
Compare
KPostOffice
force-pushed
the
workbench-certs
branch
from
b6e27ff
to
85aa438
Compare
Signed-off-by: Kevin <[email protected]>
|
/lgtm |
|
/approve |
openshift-ci
bot
added
the
approved
ChristianZaccaria
approved these changes
May 23, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: astefanutti, ChristianZaccaria The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit f96c3e3
into
project-codeflare:main
4 checks passed
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
supersedes #489
What changes have been made
I made a minor change to #489 since @Bobbins228 is out. This change makes sure the explicitly passed arg takes priority over the default
Verification steps
Checks