Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip namespace deletion for upgrade testing #550

Merged
merged 1 commit into from
May 31, 2024

Conversation

Srihari1192
Copy link
Contributor

@Srihari1192 Srihari1192 commented May 31, 2024

Issue link

https://issues.redhat.com/browse/RHOAIENG-7032

What changes have been made

Removed namespace deletion in TestMnistJobSubmit as after post upgrade job submission needs to verify in Distributed workload resource usages in UI

Verification steps

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@sutaakar
Copy link
Contributor

Who/what code will be responsible for deleting the namespace?

@Srihari1192
Copy link
Contributor Author

Who/what code will be responsible for deleting the namespace?

Namespace deletion will be taken care in ods-ci upgrade tests as part of teardown

@sutaakar
Copy link
Contributor

What is the use case?
To start RayCluster, do the upgrade and after upgrade to verify that UI shows correct values?

If it is so, can you use same approach as in red-hat-data-services/ods-ci#1467 ?

@Srihari1192
Copy link
Contributor Author

What is the use case? To start RayCluster, do the upgrade and after upgrade to verify that UI shows correct values?

If it is so, can you use same approach as in red-hat-data-services/ods-ci#1467 ?

The Use case which i am implementing is

  • In pre-upgrade scenario Run TestMNISTRayClusterUp verify Ray cluster up scenario and check resource usage in UI that showing correct values
  • In post upgrade scenario Run TestMnistJobSubmit and verify Ray cluster exists, submit job, monitor job submission status and check resource usage in UI that showing correct values

Yes we can use this approach red-hat-data-services/ods-ci#1467 to create ray cluster but we may miss coverage of actual user usage perspective of ray cluster creation and job submission wdyt?

@sutaakar
Copy link
Contributor

hmm, I guess there is no easier way to achieve it
fine for me

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 31, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 31, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 31, 2024
Copy link
Contributor

openshift-ci bot commented May 31, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: abhijeet-dhumal, sutaakar
Once this PR has been reviewed and has the lgtm label, please assign astefanutti for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dimakis dimakis merged commit a057ac1 into project-codeflare:main May 31, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants