Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle error when unable to get instascale-ocm-secret #88

Closed
Fiona-Waters opened this issue Jun 21, 2023 · 0 comments
Closed

Handle error when unable to get instascale-ocm-secret #88

Fiona-Waters opened this issue Jun 21, 2023 · 0 comments
Assignees

Comments

@Fiona-Waters
Copy link
Contributor

Update this https://github.com/project-codeflare/instascale/blob/main/controllers/appwrapper_controller.go#L172 -
we want to fail the reconciliation and update the status of the reconciled resource e.g. in a condition, so it's clear for the end-user that there is an issue with the secret configuration.
Follow on to #83 #81

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants