-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating rbacs and logging error #83
Updating rbacs and logging error #83
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are two independent changes -- they should be two separate commits. One for the logging change, one for the role change.
a2cf4b1
to
636c73e
Compare
I am testing instascale on an OSD cluster and I am seeing RBAC issues too. Besides the
which seems to come from instascale/controllers/machinepools.go Lines 86 to 90 in 810f6c0
I believe this should also be added |
e48b21f
to
fde1918
Compare
Resolves #81
While working through the quick start guide instascale logs showed that the instascale-ocm-secret could not be found.
I updated the rbacs to include secrets. I also updated the error log to include the related error in the output.