use context to create new loggers #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KPostOffice
force-pushed
the
context_logger
branch
from
a7a0aca to
9000adf
Compare
|
/lgtm |
KPostOffice
force-pushed
the
context_logger
branch
from
9000adf to
d1e619b
Compare
KPostOffice
force-pushed
the
context_logger
branch
from
d1e619b to
a9c5d25
Compare
VanillaSpoon
reviewed
Dec 4, 2023
KPostOffice
force-pushed
the
context_logger
branch
2 times, most recently
from
cb865c1 to
98517cf
Compare
Signed-off-by: Kevin <[email protected]>
KPostOffice
force-pushed
the
context_logger
branch
from
98517cf to
88f43d6
Compare
|
/lgtm thanks @KPostOffice :) |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: astefanutti The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit fafee56
into
project-codeflare:main
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
project-codeflare/codeflare-operator#113
What changes have been made
Use the controller runtime logger everywhere with structured logging. The logger is generated based on the current context object. In the linked issue there is talk about using
.WithNamebut I'm unsure if this is necessary.Verification steps
Run controller and see new structured logs.
Checks