Enable LendingLimit feature gate (#27)

project-codeflare · Jul 22, 2024 · 20f64c0 · 20f64c0
1 parent 39f77cc
commit 20f64c0
Show file tree

Hide file tree

Showing 9 changed files with 22 additions and 0 deletions.
diff --git a/setup.RHOAI-v2.10/CLUSTER-SETUP.md b/setup.RHOAI-v2.10/CLUSTER-SETUP.md
@@ -74,6 +74,7 @@ as follows:
   - `manageJobsWithoutQueueName` is enabled,
   - `batch/job` integration is disabled,
   - `waitForPodsReady` is disabled,
+  - `LendingLimit` feature gate is enabled,
 - Codeflare operator:
   - the AppWrapper controller is enabled and configured as follows:
     - `userRBACAdmissionCheck` is disabled,

diff --git a/setup.RHOAI-v2.10/mlbatch-subscription.yaml b/setup.RHOAI-v2.10/mlbatch-subscription.yaml
@@ -200,6 +200,7 @@ data:
             args:
             - "--config=/controller_manager_config.yaml"
             - "--zap-log-level=2"
+            - "--feature-gates=LendingLimit=true"
             volumeMounts:
             - name: manager-config
               mountPath: /controller_manager_config.yaml

diff --git a/setup.RHOAI-v2.11/CLUSTER-SETUP.md b/setup.RHOAI-v2.11/CLUSTER-SETUP.md
@@ -74,6 +74,7 @@ as follows:
   - `manageJobsWithoutQueueName` is enabled,
   - `batch/job` integration is disabled,
   - `waitForPodsReady` is disabled,
+  - `LendingLimit` feature gate is enabled,
 - Codeflare operator:
   - the AppWrapper controller is enabled and configured as follows:
     - `userRBACAdmissionCheck` is disabled,

diff --git a/setup.RHOAI-v2.11/mlbatch-subscription.yaml b/setup.RHOAI-v2.11/mlbatch-subscription.yaml
@@ -202,6 +202,7 @@ data:
             args:
             - "--config=/controller_manager_config.yaml"
             - "--zap-log-level=2"
+            - "--feature-gates=LendingLimit=true"
             volumeMounts:
             - name: manager-config
               mountPath: /controller_manager_config.yaml

diff --git a/setup.k8s-v1.25/CLUSTER-SETUP.md b/setup.k8s-v1.25/CLUSTER-SETUP.md
@@ -78,6 +78,7 @@ operators as follows:
   - `manageJobsWithoutQueueName` is enabled,
   - `batch/job` integration is disabled,
   - `waitForPodsReady` is disabled,
+  - `LendingLimit` feature gate is enabled,
 - AppWrapper operator:
   - `userRBACAdmissionCheck` is disabled,
   - `schedulerName` is set to `scheduler-plugins-scheduler`,

diff --git a/setup.k8s-v1.25/kueue/kustomization.yaml b/setup.k8s-v1.25/kueue/kustomization.yaml
@@ -44,3 +44,10 @@ patches:
         - get
         - list
         - watch
+- target:
+    kind: Deployment
+    name: controller-manager
+  patch: |
+    - op: add
+      path: /spec/template/spec/containers/0/args/-
+      value: "--feature-gates=LendingLimit=true"
diff --git a/setup.k8s-v1.30/CLUSTER-SETUP.md b/setup.k8s-v1.30/CLUSTER-SETUP.md
@@ -76,6 +76,7 @@ operators as follows:
   - `gang-scheduler-name` is set to `scheduler-plugins-scheduler`,
 - Kueue:
   - `waitForPodsReady` is disabled,
+  - `LendingLimit` feature gate is enabled,
 - AppWrapper operator:
   - `userRBACAdmissionCheck` is disabled,
   - `schedulerName` is set to `scheduler-plugins-scheduler`,

diff --git a/setup.k8s-v1.30/kueue/kustomization.yaml b/setup.k8s-v1.30/kueue/kustomization.yaml
@@ -44,3 +44,10 @@ patches:
         - get
         - list
         - watch
+- target:
+    kind: Deployment
+    name: controller-manager
+  patch: |
+    - op: add
+      path: /spec/template/spec/containers/0/args/-
+      value: "--feature-gates=LendingLimit=true"
diff --git a/setup.tmpl/CLUSTER-SETUP.md.tmpl b/setup.tmpl/CLUSTER-SETUP.md.tmpl
@@ -100,6 +100,7 @@ as follows:
   - `manageJobsWithoutQueueName` is enabled,
   - `batch/job` integration is disabled,
   - `waitForPodsReady` is disabled,
+  - `LendingLimit` feature gate is enabled,
 - Codeflare operator:
   - the AppWrapper controller is enabled and configured as follows:
     - `userRBACAdmissionCheck` is disabled,
@@ -158,6 +159,7 @@ operators as follows:
   - `batch/job` integration is disabled,
 {{- end }}
   - `waitForPodsReady` is disabled,
+  - `LendingLimit` feature gate is enabled,
 - AppWrapper operator:
   - `userRBACAdmissionCheck` is disabled,
   - `schedulerName` is set to `scheduler-plugins-scheduler`,