Add missing clusterqueue edit role in RHOAI 2.12 (#48)

project-codeflare · Sep 5, 2024 · d00fa6d · d00fa6d
1 parent 236dd87
commit d00fa6d
Show file tree

Hide file tree

Showing 6 changed files with 46 additions and 0 deletions.
diff --git a/setup.RHOAI-v2.10/CLUSTER-SETUP.md b/setup.RHOAI-v2.10/CLUSTER-SETUP.md
@@ -101,6 +101,7 @@ kueue-controller-manager's log:
 
 ```
 
+
 ## Kueue Configuration
 
 Create Kueue's default flavor:

diff --git a/setup.RHOAI-v2.11/CLUSTER-SETUP.md b/setup.RHOAI-v2.11/CLUSTER-SETUP.md
@@ -101,6 +101,7 @@ kueue-controller-manager's log:
 
 ```
 
+
 ## Kueue Configuration
 
 Create Kueue's default flavor:

diff --git a/setup.RHOAI-v2.12/CLUSTER-SETUP.md b/setup.RHOAI-v2.12/CLUSTER-SETUP.md
@@ -101,6 +101,11 @@ kueue-controller-manager's log:
 
 ```
 
+Apply this patch:
+```sh
+oc apply -f setup.RHOAI-v2.12/mlbatch-rbac-fix.yaml
+```
+
 ## Kueue Configuration
 
 Create Kueue's default flavor:

diff --git a/setup.RHOAI-v2.12/UPGRADE.md b/setup.RHOAI-v2.12/UPGRADE.md
@@ -31,4 +31,9 @@ value on your cluster:
 oc patch ip -n redhat-ods-operator --type merge --patch '{"spec":{"approved":true}}' install-st8vh
 ```
 
+Apply this patch:
+```sh
+oc apply -f setup.RHOAI-v2.12/mlbatch-rbac-fix.yaml
+```
+
 Finally, create the Slack Cluster Queue as described in [CLUSTER-SETUP.md for RHOAI 2.12](./CLUSTER-SETUP.md#Slack-Cluster-Queue).
diff --git a/setup.RHOAI-v2.12/mlbatch-rbac-fix.yaml b/setup.RHOAI-v2.12/mlbatch-rbac-fix.yaml
@@ -0,0 +1,28 @@
+apiVersion: rbac.authorization.k8s.io/v1
+kind: ClusterRole
+metadata:
+  name: mlbatch-clusterqueue-edit
+rules:
+- apiGroups:
+  - kueue.x-k8s.io
+  resources:
+  - clusterqueues
+  verbs:
+  - get
+  - list
+  - patch
+  - update
+  - watch
+---
+apiVersion: rbac.authorization.k8s.io/v1
+kind: ClusterRoleBinding
+metadata:
+  name: mlbatch-clusterqueue-rolebinding
+roleRef:
+  apiGroup: rbac.authorization.k8s.io
+  kind: ClusterRole
+  name: mlbatch-clusterqueue-edit
+subjects:
+- kind: ServiceAccount
+  name: codeflare-operator-controller-manager
+  namespace: redhat-ods-applications
diff --git a/setup.tmpl/CLUSTER-SETUP.md.tmpl b/setup.tmpl/CLUSTER-SETUP.md.tmpl
@@ -126,6 +126,12 @@ kueue-controller-manager's log:
 {"level":"info","ts":"2024-06-25T20:17:25.689743757Z","logger":"setup","caller":"jobframework/setup.go:81","msg":"Set up controller and webhook for job framework","jobFrameworkName":"kubeflow.org/pytorchjob"}
 
 ```
+{{ if eq .VERSION "RHOAI-v2.12" }}
+Apply this patch:
+```sh
+{{ .KUBECTL }} apply -f setup.{{ .VERSION }}/mlbatch-rbac-fix.yaml
+```
+{{- end }}
 {{- else -}}
 ## Install Operators
Original file line number	Diff line number	Diff line change
Expand Up		@@ -101,6 +101,7 @@ kueue-controller-manager's log:

		```


		## Kueue Configuration

		Create Kueue's default flavor:
Expand Down