Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce that numRocGdr must be 0 unless numProcs > 1 #63

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Enforce that numRocGdr must be 0 unless numProcs > 1 #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tools/pytorchjob-generator/chart/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ customize the Jobs generated by the tool.
| Key | Type | Default | Description |
|-----|------|---------|-------------|
| roceGdrResName | string | nvidia.com/roce_gdr | RoCE GDR resource name (can vary by cluster configuration) |
| numRoceGdr | integer | `0` | number of nvidia.com/roce_grd resources (0 means disabled; >0 means enable GDR over RoCE). |
| numRoceGdr | integer | `0` | number of nvidia.com/roce_grd resources (0 means disabled; >0 means enable GDR over RoCE). Must be 0 unless numPods > 1. |
| topologyFileConfigMap | string | `nil` | Name of configmap containining /var/run/nvidia-topologyd/virtualTopology.xml for the system e.g. nvidia-topo-gdr |
| ncclGdrEnvConfigMap | string | `nil` | Name of configmap containing NCCL networking environment variables for the system e.g. nccl-netwk-env-vars |
| multiNicNetworkName | string | `nil` | Name of multi-NIC network, if one is available. Note: when GDR over RoCE is used/available, the RoCE multi-nic network instance should be specified here instead of the TCP multi-nic network instance. Existing instance names can be listed with `oc get multinicnetwork`. |
Expand Down
13 changes: 12 additions & 1 deletion tools/pytorchjob-generator/chart/values.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@
{ "type": "null" },
{ "type": "string" }
]},
"numRoceGdr": { "type": "integer" },
"numRoceGdr": { "type": "integer", "minimum": 0, "maximum": 2 },
"topologyFileConfigMap": { "oneOf": [
{ "type": "null" },
{ "$ref": "#/$defs/rfc1123Label" }
Expand Down Expand Up @@ -134,6 +134,17 @@
"deletionOnFailureGracePeriodDuration" : { "$ref": "#/$defs/duration" }
},

"if": {
"properties": {
"numPods": { "const": 1 }
}
},
"then": {
"properties": {
"numRoceGdr": { "const": 0 }
}
},

"$defs": {
"rfc1123Label": {
"type": "string",
Expand Down
2 changes: 1 addition & 1 deletion tools/pytorchjob-generator/chart/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ volumes:
# @section -- Advanced Options
roceGdrResName: # <optional, default="">

# -- (integer) number of nvidia.com/roce_grd resources (0 means disabled; >0 means enable GDR over RoCE).
# -- (integer) number of nvidia.com/roce_grd resources (0 means disabled; >0 means enable GDR over RoCE). Must be 0 unless numPods > 1.
# @section -- Advanced Options
numRoceGdr: 0

Expand Down