Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update e2e-test-kind to pull image from quay.io #667

Merged

Conversation

tedhtchang
Copy link
Member

Issue link

Closes #661

What changes have been made

echo-server:1.0 pulled from quay.io instead of dockerhub.io

Verification steps

Re-run e2e-test-kind

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@tedhtchang tedhtchang changed the title pull image from quay.io update e2e-test-kind to pull image from quay.io Oct 19, 2023
@tedhtchang tedhtchang changed the title update e2e-test-kind to pull image from quay.io Update e2e-test-kind to pull image from quay.io Oct 19, 2023
@tedhtchang
Copy link
Member Author

@asm582 could you give this a try on your M1 laptop.

Copy link
Contributor

@KPostOffice KPostOffice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

I pulled both images and checked their hashes. They look like they should be exactly the same images. The rest of the changes are just white space removal from what I can tell.

@openshift-ci
Copy link

openshift-ci bot commented Oct 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anishasthana, KPostOffice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit f60a1f8 into project-codeflare:main Oct 30, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update registry to Quay.io in run-e2e-kind.sh
3 participants