remove: nodechecks function as it is not being used

[VanillaSpoon]

What changes have been made

Removal of the unused function

Checks

• I've made sure the tests are passing.
• Testing Strategy
  • Unit tests
  • Manual tests
  • Testing is not required for this change

[VanillaSpoon]

/retest

[ChristianZaccaria]

Nice one! It looks like it's not being used anywhere, in fact, it was a function created 2 years ago and seems never modified since then. I think it's safe to remove.

There are a number of functions in that file that are not being used as well. For example:

multi-cluster-app-dispatcher/pkg/controller/queuejob/queuejob_controller_ex.go

Line 2265 in 280e750

func (c *EtcdErrorClassifier) Classify(err error) retrier.Action {

That one in particular was created 4 months ago and is not used, and not updated since then. Wondering if a clean-up of all unused functions is a good idea given they won't be used again in the future.

cc: @astefanutti @z103cb interested in your thoughts on doing a complete clean-up on unused functions as a follow-up to this PR?

[ChristianZaccaria]

@VanillaSpoon you can retest by adding a comment and pushing changes to this PR. /retest should work but I think there's some bug in the OpenShift CI that needs to be fixed. I created this issue to see if people have any comments on it: #685

[ChristianZaccaria]

/LGTM thanks @VanillaSpoon !

[astefanutti]

/lgtm

[astefanutti]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astefanutti, ChristianZaccaria

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [astefanutti]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[astefanutti]

cc: @astefanutti @z103cb interested in your thoughts on doing a complete clean-up on unused functions as a follow-up to this PR?

@ChristianZaccaria that sounds desirable / reasonable to me 👍🏼.