Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark Hive/Deprecated Mushroom Grove transition issues in 1.16 #11

Closed
Tracked by #4
irydacea opened this issue Aug 3, 2020 · 1 comment
Closed
Tracked by #4

Dark Hive/Deprecated Mushroom Grove transition issues in 1.16 #11

irydacea opened this issue Aug 3, 2020 · 1 comment
Assignees

Comments

@irydacea
Copy link
Member

irydacea commented Aug 3, 2020

There are some issues with Dark Hive transitions when the Deprecated Mushroom Grove (^Uf/^Ufi) is involved in the Wesnoth dev branch. Either the mushroom "base" transitions into Dark Hive when the mushroom overlays Dark Hive, or Dark Hive doesn't transition into the mushroom "base" when it doesn't.

AtS E1S9.3 NW (master@311b4a016e291211651bea3337531539fc9c7d9d):

image

AtS E1S9.3 NW (1.14@a5315aad658636610ff586b506a62ae07e45c975):

image

Note: Haven't tested the new Mushroom Grove yet. It's not in my best interest to deal with the technical and artistic complications that will arise from that until I no longer need to support Wesnoh 1.14 — see project-ethea/Invasion_from_the_Unknown#73 and project-ethea/After_the_Storm#83.

(CC #4)

@stevecotton
Copy link

Adding *^Uf* to terrain-graphics/_final.cfg#L79-L82 's lists of terrains that (IIUC) Dark Hive doesn't override the transitions for has the following results on 1.14 and 1.15; it seems to solve the issue without needing a version-specific fix.

There's still an issue for the Yhr^Uf hex, but I think that looks weird in the original version too; I read that graphic as either mushrooms growing through metal with no corrosion on the surrounding metal, or as mushrooms standing on a metal floor with no roots to support or feed them.

AtS_dark_hive_transitions

@irydacea irydacea self-assigned this Aug 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants