Add support for Rex style of callback for milestone import #231
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rex
Rex specifies 2 endpoints to send results:
positiveCallback
for positive resultsnegativeCallback
for failed / error resultsChanges
This commit adds support for the
/import/product/milestone
endpoint to accept in the DTO:callback
Request object (as before)positiveCallback
Request objectnegativeCallback
Request objectFor good result, if:
positiveCallback
is specified: use it to send callback resultcallback
Request objectFor bad result, if:
negativeCallback
is specified: use it to send callback resultcallback
Request objectIf
positiveCallback
andnegativeCallback
objects are not specified in the request, we'll default to the current behaviour of sending the callback result to thecallback
Request object. This maintains backwards compatibility.We also refuse the request to this endpoint if:
positiveCallback
andcallback
objects are nullnegativeCallback
andcallback
objects are nullsince there'll be no way to send back the result.
Checklist: